[iOS] Fix transitioning direction of a CarouselView when position changed #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed an issue on iOS where updating position of a CarouselView always transitions from the rightsize (forward). The CarouselView always bases the direction transition on the value of prevBtnClicked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an issue on iOS where updating the position of a CarouselView programmatically would always animate the transitions from right to left even when going down on the positioncounter.
Currently the CarouselView always bases the direction transition on the value of
prevBtnClickedeven ifShowArrowsis set to false in XAML. This PR fixes that.To reproduce this problem you can create a clean project, which includes the CarouselView and the ShowArrows is set to true, and press the previous arrow.